[Fleet] Show all integration assets on detail page #182180
Conversation
…h returns the registered saved object app url, if any (basically only works for Kibana assets)
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
jen-huang
added
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
jen-huang
added
release_note:enhancement
and removed
release_note:feature
jen-huang
changed the title
| (!pkgInstallationInfo?.installed_kibana || | ||
| pkgInstallationInfo.installed_kibana.length === 0) | ||
| ) { | ||
| // if assets are installed in a different space no need to attempt to load them. |
There was a problem hiding this comment.
I am wondering if we could still display the ES assets in a different space, as those are not space aware e.g. if nginx was added to space A, index templates, ingest pipelines, etc. will be available in the default space too.
There was a problem hiding this comment.
I think we should try to display the ES assets regardless of the installed_kibana_space_id on the integration, as those assets are not tied to spaces.
There was a problem hiding this comment.
great catch! I missed this part of the original code. thanks @juliaElastic
|
@kpollich @juliaElastic @nimarezainia I made adjustments for if the integration is installed in a different space. We can actually show the entire list of assets including the Kibana assets that belong in a different space, but only by ID and not name. I'm not sure if this is preferable over just hiding all the Kibana assets. What do you think?
|
|
@elasticmachine merge upstream |
I think I'd rather just hide the Kibana assets in other spaces, and just show the ES assets with along with the "Kibana assets are not available in this space" callout we already include. Semantically I think "Kibana assets aren't available, but here are the assets that are available" is the intent in spaces that aren't aligned with the installation's |
|
Thanks for the feedback @kpollich. I've made adjustments so that only ES assets are shown if Kibana assets were installed in a different space. We retain the callout about Kibana assets not being available in the current space. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Resolves #160555.
This PR allows all assets to be shown on Integration details > Assets tab and links them to other apps in Kibana whenever possible for viewing. Previously, only dashboards, visualizations, and saved searches were shown in this view. Now all Kibana and Elasticsearch assets are shown if the integration was installed in the user's current space.
If an integration was installed in a different space, only ES assets will be shown.
Caveats
This page lists all assets tracked on the package installation saved object after the package is installed (
installed_esandinstalled_kibana). This list differs from the summary of assets shown on the Overview tab because it includes Fleet-installed assets that are not part of the package, notably index templates, component templates, and default ingest pipelines. [Fleet] Package asset count differs after installation #182197 was created to decide how to resolve this asset count discrepency.ML and Security assets are shown but not linked. The following issues have been created for downstream teams to decide where their assets should link to: [ML][Fleet] Link to ML assets from Integration > Assets tab #182199, [Security Solution][Fleet] Link to Security assets from Integration > Assets tab #182200
Screenshots
Nginx (including in a different space)
Security Posture Management
Rapid7 Threat Command
Lateral Movement Detection
Checklist
Delete any items that are not applicable to this PR.